Fix: Disallow structs in getters for old encoder. #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
reviewed
Nov 28, 2018
| * Optimizer: Fix nondeterminism bug related to the boost version and constants representation. The bug only resulted in less optimal but still correct code because the generated routine is always verified to be correct. | ||
| * Type Checker: Properly detect different return types when overriding an external interface function with a public contract function. | ||
| * Type Checker: Disallow struct return types for getters of public state variables unless the new ABI encoder is active. |
There was a problem hiding this comment.
The code seems to allow simple structs though.
There was a problem hiding this comment.
Yeah, need to think whether this can be rephrased, but it's hard. If the resulting type is only a struct, then it is broken up and the getter actually returns multiple values instead of a struct.
erak
reviewed
Nov 28, 2018
Codecov Report
@@ Coverage Diff @@
## develop #5526 +/- ##
===========================================
- Coverage 88.19% 88.18% -0.02%
===========================================
Files 319 319
Lines 31650 31659 +9
Branches 3792 3797 +5
===========================================
+ Hits 27914 27917 +3
Misses 2459 2459
- Partials 1277 1283 +6
|
chriseth
force-pushed
the
fixGetterNewCoder
branch
from
c762453 to
9ba3532
Compare
|
Updated. |
erak
approved these changes
Nov 28, 2018
|
I really, really don't understand codecov... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5520