Add support for EXTCODEHASH #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4676 +/- ##
===========================================
- Coverage 87.92% 87.91% -0.01%
===========================================
Files 314 314
Lines 31766 31779 +13
Branches 3748 3749 +1
===========================================
+ Hits 27930 27940 +10
- Misses 2572 2575 +3
Partials 1264 1264
|
axic
reviewed
Aug 4, 2018
libevmasm/Instruction.h
Outdated
| @@ -82,6 +82,7 @@ enum class Instruction: uint8_t | |||
| EXTCODECOPY, ///< copy external code (from another contract) | |||
| RETURNDATASIZE = 0x3d, ///< get size of return data buffer | |||
| RETURNDATACOPY = 0x3e, ///< copy return data in current environment to memory | |||
| EXTCODEHASH = 0x3f, | |||
axic
reviewed
Aug 4, 2018
libevmasm/Instruction.cpp
Outdated
| @@ -215,6 +216,7 @@ static const std::map<Instruction, InstructionInfo> c_instructionInfo = | |||
| { Instruction::EXTCODECOPY, { "EXTCODECOPY", 0, 4, 0, true, Tier::ExtCode } }, | |||
| { Instruction::RETURNDATASIZE, {"RETURNDATASIZE", 0, 0, 1, false, Tier::Base } }, | |||
| { Instruction::RETURNDATACOPY, {"RETURNDATACOPY", 0, 3, 0, true, Tier::VeryLow } }, | |||
| { Instruction::EXTCODESIZE, { "EXTCODEHASH", 0, 1, 1, false, Tier::ExtCode } }, | |||
axic
reviewed
Aug 4, 2018
| @@ -112,6 +112,7 @@ GasMeter::GasConsumption GasMeter::estimateMax(AssemblyItem const& _item, bool _ | |||
| gas += wordGas(GasCosts::copyGas, m_state->relativeStackElement(-2)); | |||
| break; | |||
| case Instruction::EXTCODESIZE: | |||
| case Instruction::EXTCODEHASH: | |||
| gas = GasCosts::extCodeGas(m_evmVersion); | |||
There was a problem hiding this comment.
Ah I'm sorry, - it seems to be the same as Instruction::BALANCE.
|
Needs a changelog entry and tests too (see tests for create2). |
|
Will take this over. |
|
Is it accepted for constantinople in the same way as shift instructions are? |
|
@chriseth rebase and fixed this. |
axic
force-pushed
the
extcodehash
branch
2 times, most recently
from
155e783 to
054932b
Compare
axic
previously approved these changes
Sep 26, 2018
|
@chriseth I think this is fine to merge. (Also needed for creating tests in github.com/ethereum/tests) |
|
@chriseth added documentation |
axic
reviewed
Sep 26, 2018
| | | | | keccak256(<address> . n . keccak256(mem[p...(p+s))) and send v | | ||
| | | | | wei and return the new address | | ||
| | | | | keccak256(0xff . <address> . n . keccak256(mem[p...(p+s))) | | ||
| | | | | and send v wei and return the new address | |
chriseth
reviewed
Sep 26, 2018
| | create(v, p, s) | | F | create new contract with code mem[p...(p+s)) and send v wei | | ||
| | | | | and return the new address | | ||
| +-------------------------+-----+---+-----------------------------------------------------------------+ | ||
| | create2(v, n, p, s) | | C | create new contract with code mem[p...(p+s)) at address | | ||
| | | | | keccak256(<address> . n . keccak256(mem[p...(p+s))) and send v | | ||
| | | | | wei and return the new address | | ||
| | | | | keccak256(0xff . <address> . n . keccak256(mem[p...(p+s))) | |
There was a problem hiding this comment.
could use u256(n) to clarify padding?
There was a problem hiding this comment.
Started doing that but ran into a lot more to explain. Will prepare a separate PR.
chriseth
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for
EXTCODEHASHopcode support in Solidity. For now, this seems to work with LLL assembly, which is what I am using to write someEXTCODEHASHstate tests.Implements https://eips.ethereum.org/EIPS/eip-1052