Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback constructor #3912

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fix fallback constructor #3912

merged 2 commits into from
Apr 18, 2018

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Apr 17, 2018 •
edited
Loading

Fixes #3904
Fixes #3911

@chriseth chriseth requested a review from axic April 17, 2018 09:48
@chriseth chriseth force-pushed the fixFallbackConstructor branch from 02efbf8 to 015684c Compare April 17, 2018 09:50
@chriseth chriseth force-pushed the fixFallbackConstructor branch from 015684c to 29a97f1 Compare April 18, 2018 12:24
axic
axic approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified the test extraction one-by-one, but the code change looks good.

@chriseth chriseth merged commit 85687a3 into develop Apr 18, 2018
@chriseth
Copy link
Contributor Author

Yeah, for the test extraction, you mostly have to trust the author. Perhaps we could somehow create an automated tool?

@axic axic deleted the fixFallbackConstructor branch April 18, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriseth @axic