documentation field added to ContractDefinition-Node #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case to |
pirapira
reviewed
Jun 1, 2017
test/libsolidity/JSONCompiler.cpp
Outdated
| @@ -92,7 +92,7 @@ BOOST_AUTO_TEST_CASE(basic_compilation) | |||
| BOOST_CHECK(dev::jsonCompactPrint(result["sources"]["fileA"]["AST"]) == | |||
| "{\"attributes\":{\"absolutePath\":\"fileA\",\"exportedSymbols\":{\"A\":[1]}}," | |||
| "\"children\":[{\"attributes\":{\"baseContracts\":[null],\"contractDependencies\":[null]," | |||
| "\"contractKind\":\"contract\",\"fullyImplemented\":true,\"linearizedBaseContracts\":[1]," | |||
| "\"contractKind\":\"contract\",\"documentation\":null,\"fullyImplemented\":true,\"linearizedBaseContracts\":[1]," | |||
There was a problem hiding this comment.
The new indentation seems to follow the coding standard, but the line stands out. Maybe in a separate commit, you can fix the indentation around here.
|
@djudjuu please add a test that has a non-null documentation node, and also one that has a line break in the documentation. |
|
@chriseth there already is one non-null documentation-test in ASTJSON.cpp. do you want me to add another one? |
djudjuu
force-pushed
the
ASTDocumentationEntry
branch
from
01f17da to
ebdebc7
Compare
|
@djudjuu would be nice to have a dedicated test in Also can you add tests for non-legacy mode? |
chriseth
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adresses #2243