Output selection tests #15447
Merged
Output selection tests #15447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
commented
Sep 23, 2024
| }, | ||
| "settings": { | ||
| "outputSelection": { | ||
| // FIXME: Behavior of "" is inconsistent. Sometimes it matches everything, sometimes only empty name. |
There was a problem hiding this comment.
"" seems broken. I'm going to report it as an issue. I think we should make it not work as a wildcard. Changing it is technically breaking though. Change the other way is not.
cameel
force-pushed
the
output-selection-tests
branch
from
05d24cd to
c6cb6e8
Compare
cameel
force-pushed
the
output-selection-tests
branch
from
c6cb6e8 to
3452ba0
Compare
matheusaaguiar
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #15433.
Related to #12153.
Regression tests I want in #15433 to make sure I'm not changing the current behavior of output selection. I'm not yet done with #15433, but we should have such tests in general, so we could merge them already.
Also some renaming of older tests to make them use the same convention.