Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set release date for 0.8.21 #14427

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

nikola-matic
Copy link
Collaborator

No description provided.

@nikola-matic nikola-matic mentioned this pull request Jul 19, 2023
74 tasks
@r0qs
Copy link
Member

r0qs commented Jul 19, 2023

Shouldn't this have been done before create the tag?

@nikola-matic
Copy link
Collaborator Author

Shouldn't this have been done before create the tag?

I don't know, why would it matter?

@r0qs
Copy link
Member

r0qs commented Jul 19, 2023

Because the tagged commit of the release says unreleased: https://github.com/ethereum/solidity/blob/v0.8.21/Changelog.md

If you check previous releases, the changelog of the release should have the release date: https://github.com/ethereum/solidity/blob/v0.8.20/Changelog.md

@nikola-matic
Copy link
Collaborator Author

Because the tagged commit of the release says unreleased: https://github.com/ethereum/solidity/blob/v0.8.21/Changelog.md

If you check previous releases, the changelog of the release should have the release date: https://github.com/ethereum/solidity/blob/v0.8.20/Changelog.md

Ugh, how do we solve this then?

@r0qs
Copy link
Member

r0qs commented Jul 19, 2023

I mean, the only problem with this is that now the release tarball will not contain the release date in the changelog. I guess we could fix it by merging this PR and recreating the tag on top of it. But I don't know if there is some other consequence to recreate the tag. Maybe @cameel knows.

@nikola-matic
Copy link
Collaborator Author

I mean, the only problem with this is that now the release tarball will not contain the release date in the changelog. I guess we could fix it by merging this PR and recreating the tag on top of it. But I don't know if there is some other consequence to recreate the tag. Maybe @cameel knows.

We can just delete the release and re-create it, but I'm not sure what happens with the tag though. Give me a sec.

@nikola-matic nikola-matic marked this pull request as ready for review July 19, 2023 08:55
@nikola-matic nikola-matic merged commit d9974be into develop Jul 19, 2023
@nikola-matic nikola-matic deleted the set-release-date-version-0.8.21 branch July 19, 2023 08:56
Copy link

@Cplus360 Cplus360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants