-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set release date for 0.8.21 #14427
Set release date for 0.8.21 #14427
Conversation
Shouldn't this have been done before create the tag? |
I don't know, why would it matter? |
Because the tagged commit of the release says If you check previous releases, the changelog of the release should have the release date: https://github.com/ethereum/solidity/blob/v0.8.20/Changelog.md |
Ugh, how do we solve this then? |
I mean, the only problem with this is that now the release tarball will not contain the release date in the changelog. I guess we could fix it by merging this PR and recreating the tag on top of it. But I don't know if there is some other consequence to recreate the tag. Maybe @cameel knows. |
We can just delete the release and re-create it, but I'm not sure what happens with the tag though. Give me a sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viewed
No description provided.