Remove old compatibility patch to soljson.js. #12236
Conversation
| @@ -31,6 +31,10 @@ Bugfixes: | |||
| * Yul IR Generator: Do not output empty switches/if-bodies for empty contracts. | |||
|
|
|||
|
|
|||
| Build System: | |||
| * Remove obsolete compatibility workaround for emscripten builds. | |||
There was a problem hiding this comment.
Yeah, I was wondering whether to add it... but if unexpectedly anyone tries to use soljson.js without solc-js and expects this hack, maybe nice to at least have some mention of it...
|
The hack is no longer needed due to ethereum/solc-js#470, right? Might be worth making an announcement about this. Some tools and frameworks may be still using old solc-js because it generally works and they download the binaries on their own. That was the case with Truffle until very recently. See trufflesuite/truffle#4134. They've been on 0.6.0 and even now they're only on 0.6.9 which is just barely enough to avoid this problem. I see that Waffle is still on 0.6.3 so we should give them a heads up - might be a good idea to submit an issue in their repo. |
|
We discussed it on the chat and started wondering what versions are used in general. Here's the list I compiled. Reposting it here so that it's easier to find and reference later:
|
Fixes #12235