Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent errors in AST import tests #12018

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

cameel
Copy link
Member

@cameel cameel commented Sep 23, 2021

Validation errors reported from --import-ast make ASTImportTest.sh just exit, without providing any information about the failure. This PR makes it print the information about the problematic input file and compiler's stdout/stderr.

Somewhat related to #12017 - on top of having no debug info for failing assertions, cmdlineTests.sh does not even print what little info is there.

@cameel cameel self-assigned this Sep 23, 2021
@chriseth chriseth merged commit 487c5ce into develop Sep 27, 2021
@chriseth chriseth deleted the fix-silent-errors-in-ast-import-tests branch September 27, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants