Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas costs in gas cost estimator #1247

Closed
chriseth opened this issue Oct 19, 2016 · 9 comments
Closed

Update gas costs in gas cost estimator #1247

chriseth opened this issue Oct 19, 2016 · 9 comments
Assignees

Comments

@chriseth
Copy link
Contributor

The gas costs in the estimator do not reflect the latest hard fork changes. At best, it should be possible to select which "ruleset" to use for the estimation.

@chriseth chriseth added the soon label Oct 19, 2016
@axic
Copy link
Member

axic commented Oct 19, 2016

See #1117.

@chriseth
Copy link
Contributor Author

chriseth commented Jan 3, 2017

@pirapira would you like to do this task? We should provide an option to select which rules apply. For now, we do not need to expose that option to the commandline interface, instead, we just select the latest rules in effect in the real world.

@pirapira
Copy link
Member

pirapira commented Jan 3, 2017

OK. I also noticed the nextrelease label.

@pirapira
Copy link
Member

pirapira commented Jan 5, 2017

This comes in two steps.

  • update the gas table, without supporting multiple versions (this should solve the problems for the current users)
  • support multiple versions of gas table
    • the test cases in GasMeter.cpp need to specify fee schedules

@chriseth
Copy link
Contributor Author

chriseth commented Jan 5, 2017

There are some tests that check the gas usage against cpp-ethereum, so I think with this story, we also have to update the cpp-ethereum we use as testing backend. We might want to switch to the docker image for that.

@pirapira
Copy link
Member

pirapira commented Jan 5, 2017

@chriseth I'll figure out what interface I need from eth/eth.

This was referenced Jan 13, 2017
@chriseth
Copy link
Contributor Author

I just ran the tests for the pull request and there are failures, so it will be postponed for the next release.

@chriseth
Copy link
Contributor Author

chriseth commented May 3, 2017

Will be completed in #2220

@chriseth chriseth closed this as completed May 3, 2017
axic pushed a commit that referenced this issue Nov 20, 2018
EIP-1014: Use keccak256 name instead of sha3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@axic @pirapira @chriseth and others