This repository has been archived by the owner on May 23, 2023. It is now read-only.
Switched to coincurve #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic, thanks! |
|
Tests fail atm |
|
Yeah 😫 Or do you mean the ones dealing with signatures? I didn't check because the tests were totally fubar. |
ofek
reviewed
Aug 10, 2017
ethereum/utils.py
Outdated
joeykrug
approved these changes
Aug 15, 2017
|
Done. Hi Joey :P |
|
@cag Needs a rebase. Also, do |
cag
force-pushed
the
switch-to-coincurve
branch
from
282e32c to
ac2403b
Compare
|
@cag Great, now just add |
|
@cag Sorry, it seems we need to change |
|
@joeykrug All ready |
|
@joeykrug Are we OK to merge? |
|
Merged |
|
Won't let me merge on mobile haha, will do in 5 min |
|
@joeykrug ok 👍 |
ofek
added a commit
to ofek/pyethereum
that referenced
this pull request
Aug 17, 2017
There was a an improper rebase in ethereum#777. This restores that fix.
|
Haha, you're welcome
…On Aug 16, 2017 8:11 PM, "Ofek Lev" ***@***.***> wrote:
@joeykrug <https://github.com/joeykrug> Thanks!
@cag <https://github.com/cag> Well done, and thanks for the time you
spent on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#777 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASNzw55DRUI7iEi2RGXd34jpDvRQsNVks5sY5MtgaJpZM4Ot27Y>
.
|
This was referenced Aug 17, 2017
Closed
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #713 which is meant to address #708
I accidentally deleted the original fork.
@ofek