This repository has been archived by the owner on May 23, 2023. It is now read-only.
encode_abi failed in python3 due to non-bytestrings, sha3 also required ... #254
+61
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed utf-8 string to be encoded before hashing
|
just to be clear, the contract compiles with abi_contract, but failed on encode_abi when a method in a contract was called. |
| @@ -32,6 +32,7 @@ def __init__(self, full_signature): | |||
| " name. Use %s to call %s with types %r" | |||
| % (name, sig_item['name'], encode_types)) | |||
| sig = name + '(' + ','.join(encode_types) + ')' | |||
| sig = sig.encode('utf-8') | |||
There was a problem hiding this comment.
in order to not introduce unicode in the first place, this should better be:
sig = name + b'(' + b','.join(encode_types) + b')'
|
okay, well, i did that, now a tonne of strings are considered bytes,
|
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...utf-8 string to be encoded before hashing
Unsure about the unicode encoding line, everything I've been doing supports unicode, but I can see why it might be favourable to force 'murica-text for method calls.