Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF Implementers Call #55 #1115

Closed
poojaranjan opened this issue Jul 24, 2024 · 5 comments
Closed

EOF Implementers Call #55 #1115

poojaranjan opened this issue Jul 24, 2024 · 5 comments
Labels
Breakout Type: Topic-specific breakout calls EOF Series: EVM Object Format Execution Layer: Issues that affect the execution layer

Comments

@poojaranjan
Copy link
Contributor

poojaranjan commented Jul 24, 2024

Meeting Info

Aug 7th, 2024 , 15:00 UTC

Duration: 60 minutes

Zoom: https://us02web.zoom.us/j/88940506383?pwd=aTdsbHVyMTNDSUFHYmhTWlI2ZEVldz09

📅 Subscribe to the Ethereum Protocol Call calendar for calendar invites

Resources

Agenda

Please add other agenda items or links to discuss.

Next call on Aug 21st, 2024

@shemnon
Copy link
Contributor

shemnon commented Aug 1, 2024

Some items to discuss relating to devnet 3 readiness

  • EVM Standard Tracing (EIP-3155 updates)
    • Add immediate arg?
    • Add section?
    • PC is zero at section, or zero from container?
    • Add some "Musts"?
      • gas must be all gas available to operation
      • PC and section must be present and correct
      • gasCost SHOULD include all dynamic costs and include gas stipend to sub call
  • Fuzzing
    • EOF Container
    • EOF Execution
  • Kurtosis
    • Who is familiar with it?
    • useful assertors to write
  • Any Testing Blindspots?
  • Devnet-3 readiness (based off of above discussions)
    • go/no-go/defer decision?

@shemnon
Copy link
Contributor

shemnon commented Aug 7, 2024

Client updates

  • Discussed EOF container validation
  • some discussion about testing

Compiler

  • need to finalize solidity PR (depends on an evmone release w/ EOF)

Spec

  • Contract Detection
    • Contracts can either disable safetransferfrom, or call out to another contract with legacy features to get the "isContract" question answered.
    • "do nothing" is the most undoable, as we can add ISCONTRACT later. But we cannot do the return code changes.
    • do nothing / fix later has momentum
  • Tracing changes
    • There was discussion of process
    • PC is zero to section
    • Maybe shorter names for section
    • Danno will write up a new EIP as a red herring, rather than modify 3155
    • goEVM lab wants nomemory and nostack options (maybe just top of stack). Make this the default?

Testing

  • Instead of Kurtosis we can use EEST consume
    • Kurtosis's main gain is it's a full client setup
    • EOF calls to the system contract would be valuable in Kurtosis. Withdrawals/deposts/other pectra calls
    • Not valuable at the moment
  • Run every test via consume
  • EEST could produce Assertoors
  • Testing blindspots
    • Need to update the checklist
    • Quantify the testing progress for next ACDE
    • Make sure all EIPs tests are in the testing checklist
  • Devnet
    • We want fuzzing ready
    • Do we need to be 100% for devnet?
      • Client should pass fuzzing
      • Clients should pass reference tests at 100% (EESTs and Ethereum/tests and evmone)
      • 7702 will be dominating devnet testing
    • Reth and Besu can join a devnet today (configuration wise)
      • Need updates from Geth, Nethermind, EthJS, Erigon

@frangio
Copy link

frangio commented Aug 7, 2024

  • Contract Detection

    • Contracts can either disable safetransferfrom, or call out to another contract with legacy features to get the "isContract" question answered.
    • "do nothing" is the most undoable, as we can add ISCONTRACT later. But we cannot do the return code changes.
    • do nothing / fix later has momentum

I'm sorry I wasn't able to be at the call today. What happened to simply reallowing EXTCODESIZE in EOF? There seemed to be a good feeling about that possibility a few weeks ago.

@shemnon
Copy link
Contributor

shemnon commented Aug 7, 2024

Reallowing EXTCODESIZE or creating ISCONTRACT I read as the top two options aside from "punt." Both of these could be introduced in the next minor version of EOF. That's the advantage of "punt" - is that it is not a permanent decision like changing return codes would be.

@poojaranjan
Copy link
Contributor Author

Closing in favor of #1128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breakout Type: Topic-specific breakout calls EOF Series: EVM Object Format Execution Layer: Issues that affect the execution layer
Projects
None yet
Development

No branches or pull requests

4 participants