change binary name "Ethereum-Wallet" to "Ethereum Wallet"

[luclu]

0.7.5 used Ethereum Wallet while
0.7.6 used Ethereum-Wallet again
as reported in #881 (OSX app consistent naming)

This PR closes #833.

Tested on OSX 10.11.5, Ubuntu 14.04 and Windows 7 x64.

[luclu]

btw.. what is this?

[evertonfraga]

idk... it isn't used across the entire project.

[hiddentao]

That code is used as part of the build process.

[frozeman]

This was used in an earlier stage of the build script. we can probably get rid of it now

[alexvandesande]

Previously I was changing the filenames manually. This change you made also would impact on the folder structure and windows platform. Not that simple

[hiddentao]

Seems to me that it's just the Mac app folder name which needs to be set. Am I right?

[frozeman]

Changing the file name will most likely have effects on other places. @luclu did you build the files and see if it all works?

[luclu]

I build and diffed all the files and folders.
The only changes happen to the binary name and the platform's folder name.
Both get set during electron-packager's name variable gulpfile.js#L301.

[frozeman]

can you remove the filenameLowercase then

[luclu]

I will try to find another variable of electron-packager to differentiate the folder from the binary name. Otherwise we might have to leverage gulp to rename it afterwards.

[frozeman]

Yeah the folder name and possible problems with some OS, or servers is why i kept the dash.
I'm not sure if introducing a lot of complicity makes sense here.

If we go that route than rather renaming the file names afterwards. The problem is renaming in gulp is not straight forward, as you need to copy, rename and delete the old one. I do this quite a lot in the current gulp script already.

So i vote for less complexity.

[luclu]

I will try to leverage https://www.npmjs.com/package/gulp-rename - haha funny nodejs world 60.000 download in the last day..

[frozeman]

we already use gulp-rename, but like i said it doesn't remove the old version, so you need to have a second step removing it yourself. It just adds complexity imo

[luclu]

On hold until #972 is merged.

[luclu]

Done in PR #1159 (former #972).

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.