Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulators/portal: update ethportal-api version for testing no union #1246

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Feb 20, 2025

Step 1

git clone hive

git clone https://github.com/ethereum/hive

Step 2

cd into hive

cd hive

Step 3

Check out PR

gh pr checkout 1246

Step 4

Compile hive

go build .

Step 5

Make sure clients.yaml contains the hash for the branch containing the no union changes for the respective client

Step 4

Run hive tests for the history network, using the no union versions

./hive -sim portal --client-file clients.yaml --sim.limit history

@acolytec3
Copy link
Contributor

Ultralight merged our PR into master so use this commit instead. a5437099da0423ed2ef0e4e42fc11e43f9a1e04c

When I run locally, Ultralight seems to build and run just fine.

@morph-dev
Copy link
Contributor

Trin PR is updated. New commit: 018a1d2caa6c2f7cc031b72f93ac1be127eacb06

@KolbyML KolbyML changed the title simulators/portal: add changes for testing no union simulators/portal: update ethportal-api version for testing no union Feb 24, 2025
Copy link
Contributor

@meldsun0 meldsun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KolbyML KolbyML merged commit dc140f3 into ethereum:master Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants