Faster multi-solution system #652
Merged
+153
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
fast-multi-sol
branch
from
fa171ea to
f3150db
Compare
msooseth
changed the title
msooseth
force-pushed
the
fast-multi-sol
branch
from
232d084 to
b2d59b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using SMT solver's incremental solving capability to vastly speed up obtaining multiple solutions
NOTE: if the number of solutions is zero, i.e. there are no valid solutions, we REVERT. This is not perfect -- what that is telling us is that in fact the whole branch we are in is nonsense. We should stop the EVM execution completely. Not sure how to do that, though, as things expect a return value, etc. So the best I could come up with is a revert.
Checklist