Frontier console node admin interface #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- require became loadScript(), no require is supplied - bignumber_js.go: heredoc v2.0.3 minified fixed for otto Regexp incompatibility https://github.com/robertkrimen/otto#regular-expression-incompatibility - bignumber.min.js also updated in mist/assets/ext - ethereum_js.go: latest master minified - assetPath in constructor - Eval/Exec/Handle/ToVal nice API - jsre tests
|
Fix the tests please |
Conflicts: cmd/ethereum/js.go javascript/types.go
| Caps string | ||
| RemoteAddress string | ||
| LocalAddress string | ||
| } |
There was a problem hiding this comment.
Why is this type necessary? Can't it just return peers directly?
Same for NodeInfo.
| @@ -251,6 +309,7 @@ func (s *Ethereum) StateDb() common.Database { return s.stateDb } | |||
| func (s *Ethereum) ExtraDb() common.Database { return s.extraDb } | |||
| func (s *Ethereum) IsListening() bool { return true } // Always listening | |||
| func (s *Ethereum) PeerCount() int { return s.net.PeerCount() } | |||
| func (s *Ethereum) PeerInfo() int { return s.net.PeerCount() } | |||
There was a problem hiding this comment.
What is this about? Is that intended?
There was a problem hiding this comment.
Absolutely not, thanks for spotting. Will fix in #512
fjl
added a commit
that referenced
this pull request
Mar 17, 2015
Frontier console node admin interface
|
👍 |
nolash
pushed a commit
to nolash/go-ethereum
that referenced
this pull request
May 3, 2018
* swarm/network/stream: fix syncer ticker leak * swarm/network/stream: a better ticker stop for syncer SetNextBatch
ngtuna
added a commit
to ngtuna/tomochain
that referenced
this pull request
Aug 16, 2019
…gner-at-checkpoint Fix ethereum#482: Ignore order of masternodes list
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Nov 12, 2021
…thereum#23635) (ethereum#485) * core/state/snapshot: fix BAD BLOCK error when snapshot is generating * core/state/snapshot: alternative fix for the snapshot generator * add comments and minor update Co-authored-by: Martin Holst Swende <[email protected]> * core/state/snapshot: fix BAD BLOCK error when snapshot is generating * core/state/snapshot: alternative fix for the snapshot generator * add comments and minor update Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Ziyuan Zhong <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]>
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jan 6, 2023
* initial commit * safe latest error * remove json listener * fix: debug block unit test * remove jsonrpc listener from server * fix: consume network's find port in heimdall client test * update key in log while startup * linters * fix Co-authored-by: Manav Darji <[email protected]>
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Liam Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #484
This PR implements a node admin interface as speced here
https://github.com/ethereum/go-ethereum/wiki/Frontier-Console
accessible via the
adminobject in the Frontier JS Console and VMp2p server and discover/table exposes Node to support nodeInfo()
eth implements NodeInfo() and PeersInfo() to support the node admin interface
see #459