core/vm, internal/ethapi: implemented eth_injectCall #3612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obscuren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Arachnid, @fjl and @Gustav-Simonsson to be potential reviewers. |
obscuren
force-pushed
the
inject-code-rpc
branch
from
4af96c8 to
2cb9af3
Compare
obscuren
changed the title
fjl
changed the title
obscuren
force-pushed
the
inject-code-rpc
branch
from
2cb9af3 to
63df6ca
Compare
The EVM gained a new method called which allows one to call using the caller as context and runs with the given code as if it were a delegate call. The only difference is that does not take an address to get the code *from*. This functions as code injection tool.
obscuren
force-pushed
the
inject-code-rpc
branch
from
63df6ca to
ea36399
Compare
bas-vk
suggested changes
Feb 3, 2017
| @@ -570,6 +570,63 @@ func (s *PublicBlockChainAPI) doCall(ctx context.Context, args CallArgs, blockNr | |||
| return res, gas, err | |||
| } | |||
|
|
|||
| type InjectCodeArgs struct { | |||
There was a problem hiding this comment.
Add a unittest that tests json parsing for the code field. The reason is that it embeds CallArgs. If someone adds CallArgs#UnmarshalJSON that function will be called to parse the json. The result is that fields in InjectCodeArgs will be ignored and set to their default values without an error.
| Code hexutil.Bytes `json:"code"` | ||
| } | ||
|
|
||
| func (s *PublicBlockChainAPI) InjectCall(ctx context.Context, args InjectCodeArgs, blockNr rpc.BlockNumber) (hexutil.Bytes, error) { |
| to = evm.StateDB.GetAccount(caller.Address()) | ||
| ) | ||
|
|
||
| // Iinitialise a new contract and make initialise the delegate values |
|
Not sure where to put this. Would be nice to have a proposal instead of adding a custom endpoint into eth. Lets think about it for 1.6.1 |
|
timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EVM gained a new method called which allows one to call using the
caller as context and runs with the given code as if it were a delegate
call. The only difference is that does not take an address to get the
code from. This functions as code injection tool.