beacon/light: blsync'er alternate #28642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
blsync-alt
branch
from
c6b5153 to
f0baa4a
Compare
lightclient
force-pushed
the
blsync-alt
branch
2 times, most recently
from
38db7ed to
c1188aa
Compare
lightclient
changed the title
Co-authored-by: lightclient <[email protected]> Co-authored-by: Zsolt Felföldi <[email protected]>
lightclient
force-pushed
the
blsync-alt
branch
from
697032a to
e1b5757
Compare
|
closing favor of #28822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of this is copied directly from Zsolt's blsync implementation.
This is mostly working now. If you want to try it out you can run the following:
$ geth --sepolia --beacon.api=https://lodestar-sepolia.chainsafe.io --beacon.wsc=$(curl -X GET 'https://lodestar-sepolia.chainsafe.io/eth/v1/beacon/headers/finalized' | jq ".data.root" | sed 's/"//g') --log.vmodule="beacon/light/*=5"Only supports Sepolia at the moment, but easy to add some more configs if this is a direction we want to go.
I think this conveys my perspective that we can drive geth via a light client w/o adding much complexity. This change is only around 1600 diff to the LOC in geth whereas the other approach is 5000+ LOC.
Obviously there are limitations of this approach and is nowhere as fully featured as Zsolt's- but as I've argued in the past, I don't think we should provide a thorough light client picture for users and so this PR provides all the functionality that we could need in an extremely simple and easy to understand format.