Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner: fixed default gasPriceOracle min price for private networks #28487

Closed
wants to merge 1 commit into from
Closed

miner: fixed default gasPriceOracle min price for private networks #28487

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2023

Should fix #27517 and any possibly related gasPrice issues with private networks.

Currently, the default settings for the merge chains allow using the default baseFeePerGas from block header for maxPriorityFeePerGas value for transactions

Example that a tx with 12 wei is mined on Goerli testnet

https://goerli.etherscan.io/tx/0xd3aca9687bdee8ae0e1b2a6ea9c0acb950ed2f1912a4724b7064872cea708ab6

However, with non-merge private networks spawned through Geth ( Clique ) doesn't allow transactions less than 1 gwei to be confirmed by miners which causes problem since many libraries like ethers.js or hardhat uses block.baseFeePerGas value by default which causes unconfirmation of transactions generated by those libraries

https://github.com/ethers-io/ethers.js/blob/main/src.ts/providers/abstract-provider.ts#L915

Therefore, this PR will fix the potential bug and will allow EIP-1559 functionality to be recovered.

( The value 2 wei matches with the default params here https://github.com/ethereum/go-ethereum/blob/master/eth/gasprice/gasprice.go#L39 )

@karalabe
Copy link
Member

karalabe commented Nov 9, 2023

The defaults are configured for Ethereum mainnet. If a fork of Geth/Ethereum wishes to behave differently, it's on them to correct their configs and ensure the updated values are run by their users.

@karalabe karalabe closed this Nov 9, 2023
@ghost
Copy link
Author

ghost commented Nov 9, 2023

@karalabe I don't think the value works as a default value and I think it is being used as a "minimal" accepted value when Geth works as a consensus node for non-merge networks therefore I think it should be fixed. Could you tell me any clue that it is used for mainnet? Since I see that Goerli and Holesky networks could mine transactions under 1 Gwei ( Like 16 weis )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You cannot set the miner.gasPrice to 0 or the txpool.pricelimit to 0 in private chains
1 participant