Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/clef: suppress fsnotify error if keydir not exists #28160

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Sep 19, 2023

close #28132

As the keydir will be automatically created after an account is created, no error message if the watcher is failed.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.2 milestone Sep 20, 2023
@holiman holiman merged commit 5b9cbe3 into ethereum:master Sep 20, 2023
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
siosw pushed a commit to fabriqnetwork/go-ethereum that referenced this pull request Oct 16, 2023
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
As the keydir will be automatically created after an account is created, no error message if the watcher is failed.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clef logs flood CLI while entering password during new account creation
2 participants