Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: add 4844 blob fields #27963

Merged
merged 9 commits into from
Sep 14, 2023
Merged

graphql: add 4844 blob fields #27963

merged 9 commits into from
Sep 14, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 22, 2023

No description provided.

@jsvisa jsvisa requested a review from s1na as a code owner August 22, 2023 04:15
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add blobGasUsed and excessBlobGas to the block.

graphql/graphql.go Show resolved Hide resolved
graphql/graphql.go Show resolved Hide resolved
graphql/graphql.go Show resolved Hide resolved
@jsvisa jsvisa requested a review from s1na September 11, 2023 14:29
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na
Copy link
Contributor

s1na commented Sep 12, 2023

Let's wait for the spec to be merged in first.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Sep 14, 2023

Let's wait for the spec to be merged in first.

YOLO

@fjl fjl merged commit 8514d66 into ethereum:master Sep 14, 2023
1 check passed
@holiman holiman added this to the 1.13.1 milestone Sep 14, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This adds block and receipt fields for EIP-4844.

---------

Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants