Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancun-devnet-8 tracker #27925

Closed
wants to merge 6 commits into from
Closed

cancun-devnet-8 tracker #27925

wants to merge 6 commits into from

Conversation

lightclient
Copy link
Member

This PR is tracking the changes for cancun-devnet-8. It is built atop #27511 and has the following changes applied:

@lightclient lightclient force-pushed the devnet-8 branch 4 times, most recently from 4264c53 to 946a2da Compare August 14, 2023 21:00
@holiman
Copy link
Contributor

holiman commented Aug 17, 2023

changes by me to handle 4788 in the engine api

I think those changes are now included in #27872 . PTAL (last 2 commits)

fjl
fjl reviewed Aug 18, 2023
View reviewed changes
core/genesis.go Outdated
var excessBlobGas uint64
head.ExcessBlobGas = &excessBlobGas
} else {
head.ExcessBlobGas = g.ExcessBlobGas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant. ExcessBlobGas is already appliedto the header just above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, sorry this branch is outdated. Probably shouldn't review this...

@lightclient lightclient force-pushed the devnet-8 branch 3 times, most recently from 780bd70 to edf4ab3 Compare August 22, 2023 21:58
@lightclient
Copy link
Member Author

closing this since devnet-8 is finished and most of these changes have made it into master

@prestonvanloon prestonvanloon mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe will be requested when the pull request is marked ready for review karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet will be requested when the pull request is marked ready for review gballet is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 will be requested when the pull request is marked ready for review rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi will be requested when the pull request is marked ready for review zsfelfoldi is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden will be requested when the pull request is marked ready for review MariusVanDerWijden is a code owner

@jwasinger jwasinger Awaiting requested review from jwasinger jwasinger will be requested when the pull request is marked ready for review jwasinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lightclient @holiman @fjl @spencer-tb