internal/ethapi: add more testcase for GetTransactionReceipt #27527
Conversation
There was a problem hiding this comment.
This test seems nice, but I feel like we should be putting our energy into adding rpc tests to https://github.com/ethereum/execution-apis
|
I'm going to refact the code in internal/ethapi, so test code is first introduced.
@lightclient Do you mean we should also add test cases inside https://github.com/ethereum/execution-apis/tree/main/tests/eth_getTransactionReceipt, if so, I'll file an PR in https://github.com/ethereum/execution-apis |
|
Yes exactly. You can find out more info on how to generate those tests here: https://github.com/ethereum/execution-apis/blob/main/tests/README.md |
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
|
@lightclient please take another look. I'll file another two PRs in rpctestgen and execution-api |
…m#27527) * internal/ethapi: testBackend reuse the same db Signed-off-by: jsvisa <[email protected]> * internal/ethapi: implment GetTransaction Signed-off-by: jsvisa <[email protected]> * internal/ethapi: implement GetReceipts Signed-off-by: jsvisa <[email protected]> * internal/ethapi: insert receipts and setup txlookup Signed-off-by: jsvisa <[email protected]> * internal/ethapi: add simple success tx receipt test Signed-off-by: jsvisa <[email protected]> * internal/ethapi: add case create contract Signed-off-by: jsvisa <[email protected]> * internal/ethapi: add contract call receipt Signed-off-by: jsvisa <[email protected]> * internal/ethapi: add tx notfound Signed-off-by: jsvisa <[email protected]> * internal/ethapi: add dynamic fee testcase * internal/ethapi: add accessList receipt * internal/ethapi: no need to insert receipt chain, no error * internal/ethapi: use HeaderByHash instead * internal/ethapi: add one more case --------- Signed-off-by: jsvisa <[email protected]>
…thereum#27527)" This reverts commit 6b2f1a5.
…thereum#27527)" This reverts commit 6b2f1a5.
No description provided.