Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use slices package for sorting #27486

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

danlaine
Copy link

See #27474

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not preserve the semantics of the previous implementation, which did strings.ToLower around the comparison.

@fjl fjl changed the title build; use slices package for sorting build: use slices package for sorting Jun 16, 2023
@danlaine
Copy link
Author

This change does not preserve the semantics of the previous implementation, which did strings.ToLower around the comparison.

fixed

@fjl fjl merged commit 36ca59f into ethereum:master Jun 18, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants