Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: avoid use of cgo by hard-coding maxPathSize #27447

Merged
merged 3 commits into from
Jun 19, 2023
Merged

rpc: avoid use of cgo by hard-coding maxPathSize #27447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59a316e
rpc: avoid use cgo with hardcoded maxPathSize
zchee Jun 9, 2023
cb4ab82
Update ipc_unix.go
fjl Jun 16, 2023
ca562c4
Delete constants.go
fjl Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions rpc/constants_unix.go
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions rpc/constants_unix_nocgo.go
View file
Open in desktop

This file was deleted.

10 changes: 8 additions & 2 deletions rpc/ipc_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,17 @@ import (
"github.com/ethereum/go-ethereum/log"
)

const (
// On Linux, sun_path is 108 bytes in size
// see http://man7.org/linux/man-pages/man7/unix.7.html
maxPathSize = int(108)
)

// ipcListen will create a Unix socket on the given endpoint.
func ipcListen(endpoint string) (net.Listener, error) {
// account for null-terminator too
if len(endpoint)+1 > int(max_path_size) {
log.Warn(fmt.Sprintf("The ipc endpoint is longer than %d characters. ", max_path_size-1),
if len(endpoint)+1 > maxPathSize {
fjl marked this conversation as resolved.
Show resolved Hide resolved
log.Warn(fmt.Sprintf("The ipc endpoint is longer than %d characters. ", maxPathSize-1),
"endpoint", endpoint)
}

Expand Down