Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: avoid performance tests #23304

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jul 30, 2021

Without this PR:

[user@work go-ethereum]$ go test ./tests --run TestState --count 1
ok      github.com/ethereum/go-ethereum/tests    111.655s

With this PR:

[user@work go-ethereum]$ go test ./tests --run TestState --count 1
ok      github.com/ethereum/go-ethereum/tests    54.563s

Let's see if it makes any difference on travis/appveyor

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Travis of this PR:
ok github.com/ethereum/go-ethereum/tests 103.481s coverage: 60.3% of statements
Master:
ok github.com/ethereum/go-ethereum/tests 428.601s coverage: 69.6% of statements
(With a grain of salt, we updated master to newer tests in the meantime I think)

@holiman holiman merged commit 3784e15 into ethereum:master Aug 25, 2021
@holiman holiman added this to the 1.10.9 milestone Aug 25, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 25, 2021
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants