internal/ethapi: fix panic in accesslist creation

[MariusVanDerWijden]

closes #23223

[holiman]

I guess it fixes the panic, which is good, but I'm a bit unsure of the semantics here. So we tell it to apply a tx with 0 tipcap and 0 maxTipand0` gas -- won't it panic on invalid basefee?

[holiman]

I guess it's fine since we have nobasefee=true set

[ghost]

I suggest assigning it outside of the for loop

	// gas price fallback
	if args.GasPrice == nil {
		args.GasPrice = (*hexutil.Big)(big.NewInt(0))
	}

[rjl493456442]

Why don't you use the args.toMessage() function instead? Perhaps you can re-assign the accessList after converting it to the message. So that you don't need to handle the gasPrice.

[MariusVanDerWijden]

Yep using to message now, and set the accesslist beforehand

[holiman]

internal/ethapi/api.go:1446:4: ineffectual assignment to gasPrice (ineffassign)

[holiman]

--- FAIL: TestGethClient (0.01s)

    --- FAIL: TestGethClient/TestAccessList (0.00s)

        gethclient_test.go:146: unexpected error: failed to apply transaction: 0xf1896776ada91d0cbcc861fac937cd06b86aba11cc55ba1fb264188e41e9dbbf err: max fee per gas less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, maxFeePerGas: 1 baseFee: 765625000

[MariusVanDerWijden]

This fixes an issue where sometimes the AL tracer would produce an accesslist with nil StorageKeys. This would then fail the marshaling/unmarshaling