ethclient: fix HeaderByNumber for pending block #22517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rel ethereum#22507 Date: 2021-03-17 08:07:51-05:00 Signed-off-by: meows <[email protected]>
Given 'pending' value of -1, this method used to return an error because the result could not be marshaled into a Header type. This solution implements a special case for pending headers -- which are only partially filled, missing fields mixHash and nonce ,notably -- by reading the result first into a dynamic map and then constructing a header field-by-field for expected /present values. The test is refactored to allow more flexible tests that can accomodate these expectations. Date: 2021-03-17 10:12:02-05:00 Signed-off-by: meows <[email protected]>
|
We have discussed this in the team and decided that it's not a good change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given 'pending' value of -1, this method (
Client.HeaderByNumber) usedto return an error because the result could not
be marshaled into a Header type.
This solution implements a special case for pending
headers -- which are only partially filled, missing
fields mixHash and nonce, notably -- by reading
the result first into a dynamic map and then
constructing a header field-by-field for expected/present values.
The test is refactored to allow more flexible
tests that can accommodate these expectations.