p2p/discover: slow down lookups on empty table #20389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Nov 25, 2019
p2p/discover/lookup.go
Outdated
| // for the table to fill in this case, but there is no good mechanism for that | ||
| // yet. | ||
| if len(closest.entries) == 0 { | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
After having sleeped for a whole second, wouldn't it make sense to check it.tab.closest once more before returning empty?
There was a problem hiding this comment.
Since we're now using lookupIterator exclusively, it'll just come around and trigger another lookup right after one finishes without any result.
There was a problem hiding this comment.
1 * time.Second -> time.Second?
|
QQ: Won't this have maybe some adverse effect on hive? No idea, just asking. |
|
I don't think there will be any effect on hive. |
|
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for an issue where peer discovery would busy-wait in the lookup
iterator when the node is offline for a while.