crypto/secp256k1: verify recovery ID before calling libsecp256k1 #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Mon Nov 16 18:34:54 UTC 2015 |
| func RecoverPubkey(msg []byte, sig []byte) ([]byte, error) { | ||
| if len(sig) != 65 { | ||
| return nil, errors.New("Invalid signature length") | ||
| if err := checkSignature(sig); err != nil { |
There was a problem hiding this comment.
While we're at it, let's error if len(msg) != 32
fjl
force-pushed
the
secp256k1-recover-id-verify
branch
from
0e3207b to
04a790d
Compare
Current coverage is
|
|
👍 |
1 similar comment
|
👍 |
The C library treats the recovery ID as trusted input and crashes the process for invalid values, so it needs to be verified before calling into C. This will inhibit the crash in ethereum#1983. Also remove VerifySignature because we don't use it.
They cause compiler warnings for people who don't have these directories. People with pkgsrc can add the directory through CGO_CFLAGS instead.
fjl
force-pushed
the
secp256k1-recover-id-verify
branch
from
04a790d to
e344e1d
Compare
obscuren
added a commit
that referenced
this pull request
Nov 17, 2015
crypto/secp256k1: verify recovery ID before calling libsecp256k1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C library treats the recovery ID as trusted input and crashes
the process for invalid values, so it needs to be verified before
calling into C.