Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some panics to be handled on adversarial input #196

Closed
wants to merge 2 commits into from
Closed

Some panics to be handled on adversarial input #196

wants to merge 2 commits into from

Conversation

ebuchman
Copy link
Contributor

No need to merge this. Probably we should start an Adversary folder in the Tests directory and begin to standardize this sort of thing. But here I'm pointing out that

  • NewValueFromBytes panics on some forms of bad rlp
  • ValidateTransaction panics on a bad signature (this is fixed here, by making the sig check explicit: fix panic on bad tx sender #195)

These are important because they are called more or less directly after receiving raw bytes from peers.

@fjl
Copy link
Contributor

fjl commented Nov 30, 2014

Uses of ethutil.Decode (and hopefully also ethutil.Value) will be replaced by package rlp. I'm working on it right now.

We are also working on a new peer to peer networking layer in package p2p (see #155). It will be a lot less racy.

@ebuchman
Copy link
Contributor Author

Ok awesome. Am looking forward to it. Just trying to avoid peers being able to crash clients by sending bad data.

As for the txpool, it's simply missing a sig check (rather than being rlp related). I will add the test to my other PR fixing it (#195), I simply wanted to avoid duplicating the fakeEth which is also present in #193, but now I think maybe it will be necessary to duplicate, as they serve different needs.

@obscuren
Copy link
Contributor

Please re-open if you want to work in the new rlp decoder/encoder

@obscuren obscuren closed this Nov 30, 2014
nonsense pushed a commit to nonsense/go-ethereum that referenced this pull request Feb 9, 2018
…es-validation

Mutable resources with ENS contenthashes and access validation
ngtuna added a commit to ngtuna/tomochain that referenced this pull request Sep 28, 2018
AusIV pushed a commit to NoteGio/go-ethereum that referenced this pull request Nov 12, 2020
…ter-20201001

Merge/foundation master 20201001
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022
weiihann pushed a commit to weiihann/go-ethereum that referenced this pull request Feb 23, 2023
* make BLOCKHASH return only last blockhash

* fix

* small fix
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Aug 1, 2023
…n-conditional

Support eth_sendRawTransactionConditional
atenjin pushed a commit to alt-research/go-ethereum that referenced this pull request Apr 4, 2024
params: add note about Delta, update protocol version to indicate Delta pre-release support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants