Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/storage: temporarily disable TestGetAllReferences - hashing bug #19025

Closed

Conversation

holisticode
Copy link
Contributor

This PR is to skip a test which has been shown to be flaky due to a bug in the hashing algorithm.

Until the bug is fixed, this test should remain disabled.

The bug is not related to the functionality of this test nor to the functionality it tests. To resolve the bug, further investigation is needed.

Copy link
Contributor

@nolash nolash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it instead :D

ethersphere/swarm#1211 (comment)

@holisticode
Copy link
Contributor Author

Fixed by #19028 and thus made obsolete

@holisticode holisticode closed this Feb 8, 2019
@acud acud deleted the getallrefs-test-disable branch February 11, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants