-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/evm: use block number from genesis #16569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost
cmd/evm/runner.go
Outdated
GasLimit: initialGas, | ||
GasPrice: utils.GlobalBig(ctx, PriceFlag.Name), | ||
Value: utils.GlobalBig(ctx, ValueFlag.Name), | ||
BlockNumber: big.NewInt(0).SetUint64(blockNumber), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big.NewInt(0)
-> new(big.Int)
cmd/evm/runner.go
Outdated
@@ -27,6 +27,8 @@ import ( | |||
|
|||
goruntime "runtime" | |||
|
|||
"math/big" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete all newlines form the imports and run goimports
again, it will reorder these a bit.
Thanks, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support to
evm
to use blocknumber from genesis, if provided.