eth: fix the propagation/announce order for mined blocks #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
added a commit
that referenced
this pull request
Jun 19, 2015
eth: fix the propagation/announce order for mined blocks
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Aug 30, 2024
…um#29960) (ethereum#1295) Co-authored-by: Gealber Morales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miners first announced a block to others (effectively to all), only then propagated (effectively to nobody because of the announce). This is a hotfix to change the order.