Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failing due to change in Azure library #24396

Closed
lovishpuri opened this issue Feb 15, 2022 · 6 comments
Closed

Compilation failing due to change in Azure library #24396

lovishpuri opened this issue Feb 15, 2022 · 6 comments
Labels
good first issue help wanted need:more-information type:bug

Comments

@lovishpuri
Copy link

Compilation errors due to change in Azure library "github.com/Azure/azure-storage-blob-go/azblob"

In /build/ci.go : func doPurge()

Line 1241: blobs[i].Name undefined (type invalid type has no field or method Name)

In /internal/build/azure.go

line 73: BlobItem not declared by package

And others ....
@ligi
Copy link
Member

ligi commented Feb 17, 2022

can you give more information about how you build and your environment?

@holiman
Copy link
Contributor

holiman commented Feb 17, 2022

What version of go are you using? go version
And what is the complete command and output when you do the build?

@karalabe
Copy link
Member

The Geth + build dependencies are pinned in go.mod and verified in go.sum, so you shouldn't get a different version, unless your build command is somehow ignoring the module file. If you use an older version of Go please update or run with GO111MODULE=on env var.

@MariusVanDerWijden
Copy link
Member

We discussed that we should update the Azure dependency soon in order to not break projects that use geth as a library

uji added a commit to uji/go-ethereum that referenced this issue Feb 27, 2022
@uji
go.mod: update azure-storage-blob-go
cb4f612 
update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.
@uji uji mentioned this issue Feb 27, 2022
Merged
uji added a commit to uji/go-ethereum that referenced this issue Feb 27, 2022
@uji
internal/build: fix for breaking changes of azure-storage-blob-go
15e6665 
fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.
karalabe added a commit that referenced this issue Mar 2, 2022
@uji @karalabe
internal/build: switch azure sdk from Azure/azure-storage-blob-go to …
8fddf27 
…Azure/azure-sdk-for-go/sdk/storage/azblob. (#24473)

* go.mod: update azure-storage-blob-go

update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation #24396.

* internal/build: fix for breaking changes of azure-storage-blob-go

fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation #24396.

* internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob.

* internal/build refactor appending BlobItems

* internal/build: fix azure blobstore client to include container id

Co-authored-by: Péter Szilágyi <[email protected]>
@Raihan1y
Copy link

Raihan1y commented Mar 8, 2022

Compilation errors due to change in Azure library "github.com/Azure/azure-storage-blob-go/azblob"

In /build/ci.go : func doPurge()

Line 1241: blobs[i].Name undefined (type invalid type has no field or method Name)

In /internal/build/azure.go

line 73: BlobItem not declared by package

And others ....

@karalabe
Copy link
Member

karalabe commented Mar 8, 2022

The Azure libraries have been bumped to latest on master.

@karalabe karalabe closed this as completed Mar 8, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
@uji @karalabe @JacekGlen
internal/build: switch azure sdk from Azure/azure-storage-blob-go to …
8abf3ba 
…Azure/azure-sdk-for-go/sdk/storage/azblob. (ethereum#24473)

* go.mod: update azure-storage-blob-go

update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.

* internal/build: fix for breaking changes of azure-storage-blob-go

fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.

* internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob.

* internal/build refactor appending BlobItems

* internal/build: fix azure blobstore client to include container id

Co-authored-by: Péter Szilágyi <[email protected]>
cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this issue Nov 16, 2022
@uji @karalabe @cp-wjhan
internal/build: switch azure sdk from Azure/azure-storage-blob-go to …
8ed6c77 
…Azure/azure-sdk-for-go/sdk/storage/azblob. (ethereum#24473)

* go.mod: update azure-storage-blob-go

update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.

* internal/build: fix for breaking changes of azure-storage-blob-go

fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0.
relation ethereum#24396.

* internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob.

* internal/build refactor appending BlobItems

* internal/build: fix azure blobstore client to include container id

Co-authored-by: Péter Szilágyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted need:more-information type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ligi @karalabe @holiman @lovishpuri @MariusVanDerWijden @Raihan1y