os.Mkdir called on Datadir default regardless of datadir config file setting.

[nejucomo]

I found that mkdir was being called on ~/.ethereum even when I specified a nondefault config file -conf=/some/other/path.ini and that config file has datadir = /some/other/datadir.

Looking at the code I see that utils.InitConfig calls utils.InitDataDir, in cmd.go line 106, and this seems like a bug because this will contain the default value.

Later main calls utils.InitDataDir directly, in ethereum.main.go line 34, with the correct value from the config file.

I intend to write a unittest to capture this bug, but I'm new to go and haven't figured out the best way to mock out os.Mkdir or to create a temporary file system directory for non-mock testing.

[tgerring]

This may be fixed by #368

[zelig]

outdated. new cli works different. see #567 #639