Skip to content

Commit

Permalink
Merge pull request #18371 from jeremyschlatter/patch-1
Browse files Browse the repository at this point in the history
core/types: update incorrect comment
  • Loading branch information
karalabe authored Jan 4, 2019
2 parents 391d4cb + 6537ab5 commit c1c4301
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/types/transaction.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func (tx *Transaction) AsMessage(s Signer) (Message, error) {
}

// WithSignature returns a new transaction with the given signature.
// This signature needs to be formatted as described in the yellow paper (v+27).
// This signature needs to be in the [R || S || V] format where V is 0 or 1.
func (tx *Transaction) WithSignature(signer Signer, sig []byte) (*Transaction, error) {
r, s, v, err := signer.SignatureValues(tx, sig)
if err != nil {
Expand Down

0 comments on commit c1c4301

Please sign in to comment.