Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse attrs #1035

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Parse attrs #1035

merged 3 commits into from
Jan 17, 2025

Conversation

Y-Nak
Copy link
Member

@Y-Nak Y-Nak commented Jan 15, 2025

Depends on #1033

  1. Fix missing attributes parsing/lowering
  2. Add the FromScope trait for a simple resolution from scope id to type T
  3. Tweak LSP to display the docstrings of some non-item HIR nodes.

@Y-Nak Y-Nak mentioned this pull request Jan 15, 2025
Merged
@Y-Nak Y-Nak requested a review from sbillig January 17, 2025 09:25
@sbillig sbillig merged commit 682fac9 into ethereum:fe-v2 Jan 17, 2025
7 checks passed
@Y-Nak Y-Nak deleted the parse-attrs branch January 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-Nak @sbillig