Consensus issue: initcode-size check in create2 #914

holiman · 2024-03-26T13:01:40Z

INFO [03-26|12:37:35.814] Shortcutting through abort
Consensus error
Testcase: /fuzztmp/00002797-mixed-67.json
- eelsbatch-0: /fuzztmp/eelsbatch-0-output.jsonl
  - command: /ethereum-spec-evm statetest --json --noreturndata --nomemory
- nethbatch-0: /fuzztmp/nethbatch-0-output.jsonl
  - command: /neth/nethtest -x --trace -m
- besubatch-0: /fuzztmp/besubatch-0-output.jsonl
  - command: /evmtool/bin/evm --nomemory --notime --json state-test
- erigonbatch-0: /fuzztmp/erigonbatch-0-output.jsonl
  - command: /erigon_vm --json --noreturndata --nomemory statetest
- nimbus-0: /fuzztmp/nimbus-0-output.jsonl
  - command: /nimbvm --json --noreturndata --nomemory --nostorage /fuzztmp/00002797-mixed-67.json
- evmone-0: /fuzztmp/evmone-0-output.jsonl
  - command: /evmone --trace /fuzztmp/00002797-mixed-67.json
- revm-0: /fuzztmp/revm-0-output.jsonl
  - command: /revme statetest --json /fuzztmp/00002797-mixed-67.json

To view the difference with tracediff:
        tracediff /fuzztmp/eelsbatch-0-output.jsonl /fuzztmp/nethbatch-0-output.jsonl
-------
prev:           both: {"depth":1,"pc":57,"gas":7978861,"op":245,"opName":"CREATE2","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"]}
diff:    eelsbatch-0: {"depth":1,"pc":58,"gas":7869055,"op":123,"opName":"PUSH28","stack":["0x50","0xab","0x70","0xcc","0x6c","0x0"]}
diff:    nethbatch-0: {"stateRoot":"0x33533c6e741de8fa56b689559a834e73ba2c050fa7a096f4b6b1d0c9018735c9"}

I've verified that eels is the odd one out, all other clients agree.

Minmized testcase 00002797-mixed-67.json.min:

{
  "00002797-mixed-67": {
    "env": {
      "currentCoinbase": "b94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "currentDifficulty": "0x200000",
      "currentRandom": "0x0000000000000000000000000000000000000000000000000000000000020000",
      "currentGasLimit": "0x26e1f476fe1e22",
      "currentNumber": "0x1",
      "currentTimestamp": "0x3e8",
      "previousHash": "0x044852b2a670ade5407e78fb2863c51de9fcb96542a07186fe3aeda6bb8a116d",
      "currentBaseFee": "0x10"
    },
    "pre": {
      "0x00000000000000000000000000000000000000f1": {
        "code": "0x6043605060ab607060cc606c609251194465049d3a5b5b0172fd5b623153803c715b7c8482055e49071233651b6a11531063346aa0fa774654f57b",
        "storage": {},
        "balance": "0x0",
        "nonce": "0x0"
      },
      "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "code": "0x",
        "storage": {},
        "balance": "0xffffffffff",
        "nonce": "0x0"
      }
    },
    "transaction": {
      "gasPrice": "0x10",
      "nonce": "0x0",
      "to": "0x00000000000000000000000000000000000000f1",
      "data": [
        "0xbf71a3a5d0"
      ],
      "gasLimit": [
        "0x1ff81"
      ],
      "value": [
        "0x392aca"
      ],
      "sender": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "secretKey": "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
    },
    "out": "0x",
    "post": {
      "Cancun": [
        {
          "hash": "0x0000000000000000000000000000000000000000000000000000000000000000",
          "logs": "0x0000000000000000000000000000000000000000000000000000000000000000",
          "indexes": {
            "data": 0,
            "gas": 0,
            "value": 0
          }
        }
      ]
    }
  }
}

Outputs

eel:

root@84d25ae6ae59:/# cat eels-0-output.jsonl 
{"depth":1,"pc":0,"gas":109865,"op":96,"opName":"PUSH1","stack":[]}
{"depth":1,"pc":2,"gas":109862,"op":96,"opName":"PUSH1","stack":["0x43"]}
{"depth":1,"pc":4,"gas":109859,"op":96,"opName":"PUSH1","stack":["0x43","0x50"]}
{"depth":1,"pc":6,"gas":109856,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab"]}
{"depth":1,"pc":8,"gas":109853,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70"]}
{"depth":1,"pc":10,"gas":109850,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70","0xcc"]}
{"depth":1,"pc":12,"gas":109847,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70","0xcc","0x6c"]}
{"depth":1,"pc":14,"gas":109844,"op":81,"opName":"MLOAD","stack":["0x50","0xab","0x70","0xcc","0x6c","0x92"]}
{"depth":1,"pc":15,"gas":109823,"op":25,"opName":"NOT","stack":["0x50","0xab","0x70","0xcc","0x6c","0x0"]}
{"depth":1,"pc":16,"gas":109820,"op":68,"opName":"DIFFICULTY","stack":["0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"]}
{"depth":1,"pc":17,"gas":109818,"op":101,"opName":"PUSH6","stack":["0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000"]}
{"depth":1,"pc":24,"gas":109815,"op":114,"opName":"PUSH19","stack":["0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01"]}
{"depth":1,"pc":44,"gas":109812,"op":27,"opName":"SHL","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01","0xfd5b623153803c715b7c8482055e4907123365"]}
{"depth":1,"pc":45,"gas":109809,"op":106,"opName":"PUSH11","stack":["0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0"]}
{"depth":1,"pc":57,"gas":109806,"op":245,"opName":"CREATE2","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"]}
{"depth":1,"pc":58,"gas":0,"op":123,"opName":"PUSH28","stack":["0x50","0xab","0x70","0xcc","0x6c","0x0"]}
{"stateRoot":"0xa93360d73966aff182499970e779fcf4cefad3b99129879ce658eb7d806ee8d4"}

other client (erigon):

root@84d25ae6ae59:/# cat erigon-0-output.jsonl 
{"depth":1,"pc":0,"gas":109865,"op":96,"opName":"PUSH1","stack":[]}
{"depth":1,"pc":2,"gas":109862,"op":96,"opName":"PUSH1","stack":["0x43"]}
{"depth":1,"pc":4,"gas":109859,"op":96,"opName":"PUSH1","stack":["0x43","0x50"]}
{"depth":1,"pc":6,"gas":109856,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab"]}
{"depth":1,"pc":8,"gas":109853,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70"]}
{"depth":1,"pc":10,"gas":109850,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70","0xcc"]}
{"depth":1,"pc":12,"gas":109847,"op":96,"opName":"PUSH1","stack":["0x43","0x50","0xab","0x70","0xcc","0x6c"]}
{"depth":1,"pc":14,"gas":109844,"op":81,"opName":"MLOAD","stack":["0x50","0xab","0x70","0xcc","0x6c","0x92"]}
{"depth":1,"pc":15,"gas":109823,"op":25,"opName":"NOT","stack":["0x50","0xab","0x70","0xcc","0x6c","0x0"]}
{"depth":1,"pc":16,"gas":109820,"op":68,"opName":"DIFFICULTY","stack":["0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"]}
{"depth":1,"pc":17,"gas":109818,"op":101,"opName":"PUSH6","stack":["0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000"]}
{"depth":1,"pc":24,"gas":109815,"op":114,"opName":"PUSH19","stack":["0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01"]}
{"depth":1,"pc":44,"gas":109812,"op":27,"opName":"SHL","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01","0xfd5b623153803c715b7c8482055e4907123365"]}
{"depth":1,"pc":45,"gas":109809,"op":106,"opName":"PUSH11","stack":["0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0"]}
{"depth":1,"pc":57,"gas":109806,"op":245,"opName":"CREATE2","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"]}
{"stateRoot":"0xa93360d73966aff182499970e779fcf4cefad3b99129879ce658eb7d806ee8d4"}

Diff on minimized testcase:

prev:           both: {"depth":1,"pc":57,"gas":109806,"op":245,"opName":"CREATE2","stack":["0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"]}
diff:         eels-0: {"depth":1,"pc":58,"gas":0,"op":123,"opName":"PUSH28","stack":["0x50","0xab","0x70","0xcc","0x6c","0x0"]}
diff:       erigon-0: {"stateRoot":"0x3eae60a44b8bc72e14f80dbc7ad73c0eb8d6d5152e1eaf9e66b739f8ecd89c37"}

It looks like you are emitting/executing an op even though there's 0 gas left?

The text was updated successfully, but these errors were encountered:

gurukamath · 2024-03-26T14:31:48Z

From what I can see in this case, the CREATE2 op takes exactly all the gas that is available, which means that the next op runs into OutOfGasError. So EELS does not execute the next opcode but only emits the trace for it, since the evm actually runs out of gas while attempting to run that opcode. Here is the full trace from EELS

{"pc":0,"op":96,"gas":"0x1ad29","gasCost":"0x3","memSize":0,"stack":[],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":2,"op":96,"gas":"0x1ad26","gasCost":"0x3","memSize":0,"stack":["0x43"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":4,"op":96,"gas":"0x1ad23","gasCost":"0x3","memSize":0,"stack":["0x43","0x50"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":6,"op":96,"gas":"0x1ad20","gasCost":"0x3","memSize":0,"stack":["0x43","0x50","0xab"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":8,"op":96,"gas":"0x1ad1d","gasCost":"0x3","memSize":0,"stack":["0x43","0x50","0xab","0x70"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":10,"op":96,"gas":"0x1ad1a","gasCost":"0x3","memSize":0,"stack":["0x43","0x50","0xab","0x70","0xcc"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":12,"op":96,"gas":"0x1ad17","gasCost":"0x3","memSize":0,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c"],"depth":1,"refund":0,"opName":"PUSH1"}
{"pc":14,"op":81,"gas":"0x1ad14","gasCost":"0x15","memSize":0,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0x92"],"depth":1,"refund":0,"opName":"MLOAD"}
{"pc":15,"op":25,"gas":"0x1acff","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0x0"],"depth":1,"refund":0,"opName":"NOT"}
{"pc":16,"op":68,"gas":"0x1acfc","gasCost":"0x2","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"],"depth":1,"refund":0,"opName":"PREVRANDAO"}
{"pc":17,"op":101,"gas":"0x1acfa","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000"],"depth":1,"refund":0,"opName":"PUSH6"}
{"pc":24,"op":114,"gas":"0x1acf7","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01"],"depth":1,"refund":0,"opName":"PUSH19"}
{"pc":44,"op":27,"gas":"0x1acf4","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x49d3a5b5b01","0xfd5b623153803c715b7c8482055e4907123365"],"depth":1,"refund":0,"opName":"SHL"}
{"pc":45,"op":106,"gas":"0x1acf1","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0"],"depth":1,"refund":0,"opName":"PUSH11"}
{"pc":57,"op":245,"gas":"0x1acee","gasCost":"0x1acee","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"],"depth":1,"refund":0,"opName":"CREATE2"}
{"pc":58,"op":123,"gas":"0x0","gasCost":"0x3","memSize":131072,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0x0"],"depth":1,"refund":0,"opName":"PUSH28","error":"OutOfGasError"}
{"output":"","gasUsed":"0x1ad29","error":"OutOfGasError"}

holiman · 2024-03-26T14:36:34Z

Hm. Geth (and, I suppose, the others) attribute the error to the earlier op:

{"pc":45,"op":106,"gas":"0x1acf1","gasCost":"0x3","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0"],"depth":1,"refund":0,"opName":"PUSH11"}
{"pc":57,"op":245,"gas":"0x1acee","gasCost":"0x7d00","memSize":192,"stack":["0x43","0x50","0xab","0x70","0xcc","0x6c","0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff","0x20000","0x0","0x11531063346aa0fa774654"],"depth":1,"refund":0,"opName":"CREATE2","error":"out of gas"}
{"output":"","gasUsed":"0x1ad29","error":"out of gas"}

holiman · 2024-03-26T14:49:02Z

Actually, the error is earlier:

 size > params.MaxInitCodeSize `49152`: 131072

holiman · 2024-03-29T09:11:15Z

This should have been closed by #915, no?

gurukamath · 2024-03-29T21:40:40Z

This should have been closed by #915, no?

Yes

Testcases for the eels-bugs: - [x] ethereum/execution-specs#911 - [x] ethereum/execution-specs#914 - [x] ethereum/execution-specs#917 --------- Co-authored-by: Guruprasad Kamath <[email protected]>

holiman mentioned this issue Mar 26, 2024

add trophy holiman/goevmlab#137

Open

gurukamath self-assigned this Mar 26, 2024

holiman mentioned this issue Mar 26, 2024

core/vm: better error-info for vm errors ethereum/go-ethereum#29354

Merged

holiman changed the title ~~Consensus issue found via fuzzing~~ Consensus issue: initcode-size check in create2 Mar 26, 2024

gurukamath mentioned this issue Mar 26, 2024

check create/create2 code size upfront #915

Merged

holiman closed this as completed Apr 4, 2024

holiman added a commit to holiman/goevmlab that referenced this issue Apr 7, 2024

add testcase for ethereum/execution-specs#914

b62b0be

holiman mentioned this issue Apr 8, 2024

Testcases for EELS-bugs holiman/goevmlab#140

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consensus issue: initcode-size check in create2 #914

Consensus issue: initcode-size check in create2 #914

holiman commented Mar 26, 2024

gurukamath commented Mar 26, 2024 •

edited

Loading

holiman commented Mar 26, 2024

holiman commented Mar 26, 2024

holiman commented Mar 29, 2024

gurukamath commented Mar 29, 2024

Consensus issue: initcode-size check in create2 #914

Consensus issue: initcode-size check in create2 #914

Comments

holiman commented Mar 26, 2024

gurukamath commented Mar 26, 2024 • edited Loading

holiman commented Mar 26, 2024

holiman commented Mar 26, 2024

holiman commented Mar 29, 2024

gurukamath commented Mar 29, 2024

gurukamath commented Mar 26, 2024 •

edited

Loading