Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verkle: add extra SSTORE test #936

Merged
merged 2 commits into from
Nov 7, 2024
Merged

verkle: add extra SSTORE test #936

merged 2 commits into from
Nov 7, 2024

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Nov 4, 2024

This PR adds a tests related to a disagreement found by the txfuzzer in devnet7 caused by underspec.

The bug can be described as a tx:

  • Having an abscent storage slot
  • Doing a SSTORE with a non-zero value
  • Doing a SSTORE with a zero value

The resulting value of the previously abscent storage slot is zero, and different EL clients seemed to disagree if this storage-slot value is written into the tree. The intermediary non-zero value seems to be necessary to cause the problem since different EL clients might see that as an event produce (or not) the write into the tree.

jsign added 2 commits November 4, 2024 15:09
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign marked this pull request as ready for review November 7, 2024 05:12
@jsign jsign merged commit 281da6b into verkle/main Nov 7, 2024
1 of 5 checks passed
@jsign jsign deleted the jsign-sstore-test branch November 7, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant