Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): EOF - EIP-4750: parametrize CALLF execution tests #913

Merged
merged 1 commit into from
Oct 25, 2024
Merged

refactor(tests): EOF - EIP-4750: parametrize CALLF execution tests #913

merged 1 commit into from
Oct 25, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 24, 2024 •
edited by winsvega
Loading

🗒️ Description

Use pytest parametrize to combine very similar tests for CALLF execution.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Test cases type:refactor Type: Refactor labels Oct 24, 2024
winsvega
winsvega approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. however some comments for Mario.

@pdobacz pdobacz mentioned this pull request Oct 24, 2024
Merged
marioevz
marioevz approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can merge now and follow up on Dimitry's suggestion on a separate PR.

tests/osaka/eip7692_eof_v1/eip4750_functions/test_callf_execution.py Show resolved Hide resolved
@marioevz marioevz changed the title refactor(tests): parametrize CALLF execution tests refactor(tests): EOF - EIP-4750: parametrize CALLF execution tests Oct 25, 2024
@marioevz marioevz merged commit 02d97c0 into ethereum:main Oct 25, 2024
3 checks passed
@marioevz marioevz deleted the eof/parametrize_callf_execution_tests branch October 25, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@pdobacz pdobacz pdobacz approved these changes

@winsvega winsvega winsvega approved these changes

@danceratopz danceratopz Awaiting requested review from danceratopz

Assignees
No one assigned
Labels
scope:tests Scope: Test cases type:refactor Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chfast @winsvega @pdobacz @marioevz