Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): basic EOF execution tests #912

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 24, 2024

🗒️ Description

  • Basic EOF execution tests migrated from ethereum/tests:
    EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json (filler source)
  • Extend execution test of legacy invoking EXTCODE* instruction on EOF with the case from ethereum/tests.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Oct 24, 2024
@chfast chfast force-pushed the eof/migrate_execution branch from 8c4c83a to 6ffe206 Compare October 24, 2024 10:33
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chfast chfast force-pushed the eof/migrate_execution branch from 6ffe206 to c5ad493 Compare October 24, 2024 11:00
Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
with the case from ethereum/tests.
Migrated from ethereum/tests:
EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
@chfast chfast force-pushed the eof/migrate_execution branch from c5ad493 to e2612a1 Compare October 24, 2024 11:20
@chfast chfast merged commit 0ed27a0 into ethereum:main Oct 24, 2024
2 of 5 checks passed
@chfast chfast deleted the eof/migrate_execution branch October 24, 2024 11:38
@winsvega
Copy link
Collaborator

need to merge coverage script update so it wont fail

winsvega pushed a commit that referenced this pull request Oct 25, 2024
- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.
winsvega pushed a commit that referenced this pull request Oct 25, 2024
- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.
winsvega pushed a commit that referenced this pull request Oct 25, 2024
- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.
winsvega pushed a commit that referenced this pull request Oct 25, 2024
- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.
winsvega pushed a commit that referenced this pull request Oct 25, 2024
- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.
marioevz added a commit that referenced this pull request Nov 4, 2024
* new(tests): basic EOF execution tests (#912)

- Add basic EOF execution tests migrated from ethereum/tests:
  EIPTests/StateTests/stEOF/stEIP3540/EOF1_Execution.json
- Extend execution test of legacy invoking `EXTCODE*` instruction on EOF
  with the case from ethereum/tests.

* Apply suggestions from code review

---------

Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants