Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Definitions as Classes #91

Merged
merged 8 commits into from
Mar 30, 2023
Merged

Fork Definitions as Classes #91

merged 8 commits into from
Mar 30, 2023

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Mar 30, 2023

Changes Included

Forks are now specified as a fork object instead of strings, which allows for a more coherent use of forks across the repo.

@marioevz marioevz marked this pull request as ready for review March 30, 2023 06:19
@marioevz marioevz requested a review from spencer-tb March 30, 2023 16:02
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice and clean!! LGTM

src/ethereum_test_forks/__init__.py Outdated Show resolved Hide resolved
@spencer-tb spencer-tb merged commit 5ab54a5 into main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants