Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-4750: unreachable code sections #856

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 1, 2024

🗒️ Description

This migrates tests for unreachable code sections from
EOFTests/efValidation/unreachable_code_sections_.json
but also complements test cases with focus on containers where
each section is referenced by some section but some are not reachable
from section 0.

✅ Checklist

@chfast chfast force-pushed the eof/unreachable_code_sections branch from d7b6daf to 8750cb2 Compare October 1, 2024 14:14
@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Oct 1, 2024
chfast added a commit to ipsilon/tests that referenced this pull request Oct 1, 2024
@chfast chfast requested a review from pdobacz October 1, 2024 14:33
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, lgtm!

This migrates tests for unreachable code sections from
EOFTests/efValidation/unreachable_code_sections_.json
but also complements test cases with focus on containers where
each section is referenced by some section but some are not reachable
from section 0.
@chfast chfast force-pushed the eof/unreachable_code_sections branch from 8750cb2 to e85d731 Compare October 1, 2024 16:07
@chfast chfast marked this pull request as ready for review October 1, 2024 16:15
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, it's also fine by me if it stays in this single file, thanks!

@marioevz marioevz changed the title new(tests): unreachable EOF code sections new(tests): EOF - EIP-4750: unreachable code sections Oct 1, 2024
@marioevz marioevz merged commit 77c5153 into ethereum:main Oct 1, 2024
5 checks passed
@marioevz marioevz deleted the eof/unreachable_code_sections branch October 1, 2024 17:29
winsvega pushed a commit to ethereum/tests that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants