-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fw,tests): Replace ethereum.base_types
with ethereum-types
, replace ethereum.crypto.hash
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
scope:tests
Scope: Test cases
type:chore
Type: Chore
type:refactor
Type: Refactor
scope:fw
Scope: Framework (evm|tools|forks|pytest)
labels
Sep 30, 2024
danceratopz
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Except for the issues with CI 🙈
One small comment below.
marioevz
force-pushed
the
fix-library-imports
branch
from
September 30, 2024 20:30
7904f39
to
ba54548
Compare
danceratopz
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:fw
Scope: Framework (evm|tools|forks|pytest)
scope:tests
Scope: Test cases
type:chore
Type: Chore
type:refactor
Type: Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
ethereum_types
instead ofethereum.base_types
ethereum.crypto.hash.keccak256
with internal function that directly usescoincurve
Bytes
in order to useBytes.keccak256
Bonus:
🔗 Related Issues
tox -e tests
fails with python 3.10 - reenable 3.10 matrix config in CI #852ethereum-types
execution-specs#1007✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.