Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw,tests): Replace ethereum.base_types with ethereum-types, replace ethereum.crypto.hash #850

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Sep 30, 2024

🗒️ Description

  • Use ethereum_types instead of ethereum.base_types
  • Replace uses of ethereum.crypto.hash.keccak256 with internal function that directly uses coincurve
  • Refactor some methods to return Bytes in order to use Bytes.keccak256

Bonus:

  • Bump uv version in ci.
  • Configure tox-uv (in tox.ini) to use uv.lock.
  • Configure runner as ubuntu-latest (this was bumped to ubuntu-24.04 actions/runner-images@ae99c16)

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:chore Type: Chore type:refactor Type: Refactor scope:fw Scope: Framework (evm|tools|forks|pytest) labels Sep 30, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Except for the issues with CI 🙈

One small comment below.

.github/workflows/tox_verify.yaml Show resolved Hide resolved
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 8fe1c23 into main Sep 30, 2024
5 checks passed
@marioevz marioevz deleted the fix-library-imports branch September 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases type:chore Type: Chore type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants