Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-6206: clarify "non-returning instruction" #837

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Sep 25, 2024

🗒️ Description

Recently some confusion was reported whether what are "non-returning instructions" mentioned in the test. It looks like a mental shortcut, and can also raise questions like "is RETURNCONTRACT or RETURN one?". This clarifies this and also adds some coverage for such instructions (which are basically "terminating but not RETF or JUMPF-to-returning").

Also fixes a typo in that file's name.

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz requested a review from marioevz September 25, 2024 11:24
@pdobacz pdobacz self-assigned this Sep 25, 2024
@pdobacz
Copy link
Collaborator Author

pdobacz commented Sep 25, 2024

I'll go ahead and merge here as there are no fw changes involved

@pdobacz pdobacz merged commit 156992b into ethereum:main Sep 25, 2024
4 checks passed
@pdobacz pdobacz deleted the returning-nonreturning branch September 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants