new(tests): EIP-7069 and EIP-7620 - failures and context vars #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
force-pushed
the
missing-tests
branch
from
a681c3e to
f7fd6b6
Compare
chfast
reviewed
Sep 25, 2024
chfast
approved these changes
Sep 25, 2024
pdobacz
force-pushed
the
missing-tests
branch
from
f7fd6b6 to
9ed640d
Compare
|
@marioevz When you have a moment I'd appreciate your review on this one :). |
marioevz
reviewed
Sep 25, 2024
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_eofcreate.py
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Sep 26, 2024
pdobacz
force-pushed
the
missing-tests
branch
2 times, most recently
from
b3ad2ff to
19dd416
Compare
pdobacz
force-pushed
the
missing-tests
branch
2 times, most recently
from
89417f0 to
d91b5d3
Compare
Co-authored-by: Mario Vega <[email protected]>
pdobacz
changed the title
pdobacz
force-pushed
the
missing-tests
branch
from
d91b5d3 to
df9a851
Compare
marioevz
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fills in some missing coverage regarding EXT*CALL and EOFCREATE failure modes and handling of context variables in the child context, which was reported missing recently
NOTE: should probably go after #834 so I can rebase on top and use the unified constants
🔗 Related Issues
NA
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.