-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exceptions,specs): class to verify exception strings #795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the ExceptionMapper
idea, I think it might be too t8n-focused but it could be used in many other places, e.g. exceptions from the Engine API when we run the tests in hive.
I think this PR can start with TransitionToolExceptionMapper
defined in src/evm_transition_tool
to make ExceptionMapper
a bit more generic to open the door to future PRs to implement other subclasses.
db0b38b
to
28598f3
Compare
still need to setup other clients for this. but I refactored the suggestions. can check the code. Ah, and need to enable it for state tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey it's looking great overall, but I think we need to address the comments, mainly because the default t8n to fill tests has become the execution_specs
t8n, so I think the exception mapper should be complete from the start.
8d04c8b
to
3a5677b
Compare
3a5677b
to
5d8d350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic, looking forward to using these exceptions in consume
in due course!
A few small comments below.
Fixed tox. It turns out there was an invalid transaction in the framework tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
🗒️ Description
Extent exception mapper with base class so that any t8n can define exception string maps for any exception types
I put transaction exception validation into exception mapper for convinience atm.
Example exception message:
🔗 Related Issues
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.