Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-3540: migrate tests for truncated sections #740

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 11, 2024

πŸ—’οΈ Description

Migrate tests from EOFTests/efValidation/EOF1_truncated_section_.json.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast force-pushed the eof/migrate_truncated_section branch 2 times, most recently from f52ff40 to 4049fe4 Compare August 11, 2024 18:54
Migrate tests from EOFTests/efValidation/EOF1_truncated_section_.json.
@chfast chfast force-pushed the eof/migrate_truncated_section branch from 4049fe4 to f6c9aa4 Compare August 11, 2024 19:01
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like this approach where you have the full container and then truncate it because it lets you see how the valid version looks like. Thanks!

@marioevz marioevz changed the title new(tests): migrate EOF tests for truncated sections new(tests): EOF - EIP-3540: migrate tests for truncated sections Aug 12, 2024
@marioevz marioevz merged commit 7fa7054 into ethereum:main Aug 12, 2024
6 checks passed
@marioevz marioevz deleted the eof/migrate_truncated_section branch August 12, 2024 15:40
@chfast
Copy link
Member Author

chfast commented Aug 12, 2024

LGTM. I like this approach where you have the full container and then truncate it because it lets you see how the valid version looks like. Thanks!

I had this idea for longer: take some valid containers and chop off some bytes, but the number of tests generated this way is probably too big.

chfast added a commit to ethereum/tests that referenced this pull request Aug 19, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
winsvega pushed a commit to ethereum/tests that referenced this pull request Aug 20, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants