Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Add stack validation cases to EOF tracker #735

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 8, 2024

🗒️ Description

There's a lot of testing needed for stack validation, so I split the cases into subsections.

(Note there are still many execution cases missing from the tracker, I plan to submit another batch pointing to cases generated by evmone)

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@gumb0 gumb0 force-pushed the eof-tracker-stack-validation branch from bfc4a6d to bcc0e1a Compare August 9, 2024 16:58
@gumb0 gumb0 marked this pull request as ready for review August 9, 2024 17:00
@marioevz marioevz merged commit e15ec28 into ethereum:main Aug 10, 2024
4 checks passed
@marioevz marioevz deleted the eof-tracker-stack-validation branch August 10, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants